Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide the native input for boolean elements in firefox #808

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Jun 7, 2024

Description

In boolean elements, the native input field was never truly hidden in firefox despite height/width set to 0, causing it to appear to look like dots on the screen.

Fixes umbraco/Umbraco-CMS#16515

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@loivsen loivsen requested a review from nielslyngsoe June 7, 2024 08:44
@loivsen loivsen changed the title Hides boolean elements native input for firefox Hide the native input for boolean elements in firefox Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-808.westeurope.azurestaticapps.net

Copy link

github-actions bot commented Jun 7, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-808.westeurope.azurestaticapps.net

@loivsen loivsen requested review from JesmoDev and iOvergaard June 17, 2024 08:59
@iOvergaard iOvergaard changed the title Hide the native input for boolean elements in firefox fix: Hide the native input for boolean elements in firefox Jun 17, 2024
@iOvergaard iOvergaard merged commit 81c0a95 into v1/contrib Jun 17, 2024
9 of 10 checks passed
@iOvergaard iOvergaard deleted the bugfix/hide-boolean-input-for-firefox branch June 17, 2024 09:42
@iOvergaard iOvergaard added the bug Something isn't working label Jun 17, 2024
iOvergaard pushed a commit that referenced this pull request Jun 18, 2024
* Hides the boolean input for firefox

* opacity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V14] Checkbox list causes dots everywhere
2 participants